Revision 49:1fc51c53cebf, committed 2014-08-04

Comitter:

Vanger

Date:

Mon Aug 04 22:16:18 2014 +0000

Parent:

48:3f9d82915e83

Child:

50:144099030d9b

Commit message:

Simplified sendEscapeCommand() under EasyIP.cpp and changed comments under both EasyIP.h and EasyIP.cpp

Changed in this revision

--- a/Cellular/EasyIP.cpp	Fri Aug 01 21:54:36 2014 +0000
+++ b/Cellular/EasyIP.cpp	Mon Aug 04 22:16:18 2014 +0000
@@ -44,7 +44,7 @@
     }
 
     logDebug("radio type: %s", Cellular::getRadioNames(type).c_str());
-    //Turns on the HW flow control, equiv. to AT&K
+    //Turns on the HW flow control
     if(sendBasicCommand("AT&K3", 2000) != MTS_SUCCESS) {
         logWarning("Failed to set flow control to radio");
     }
@@ -713,12 +713,11 @@
     
     std::string result;
     unsigned int timeoutMillis = 10000; //time in ms
-    const int size_cmd = 3;
     //Attempt to write command
     wait(1.2); //Format for +++ command is 1 second wait, send +++, then another second wait
              //1s wait after command is implemented as a polling function for 2 seconds
              //Option: Could change wait periods to be longer/shorter (0-255)*50ms
-    if(io->write("+++", size_cmd, timeoutMillis) != size_cmd) {
+    if(io->write("+++", 3, timeoutMillis) != 3) {
         //Failed to write command
         logError("failed to send command to radio within %d milliseconds", timeoutMillis);
         return false;

--- a/Cellular/EasyIP.h	Fri Aug 01 21:54:36 2014 +0000
+++ b/Cellular/EasyIP.h	Mon Aug 04 22:16:18 2014 +0000
@@ -9,8 +9,8 @@
 
 namespace mts
 {
-    /** This is a class for communicating without a Multi-Tech Systems SocketModem iCell. Instead, 
-    * it uses the hayes command set to directly implement the same UIP interface to the radio.
+    /** This class implements the same interface used for UIP version radios on an Easy IP radio
+    * using the Hayes AT command set.
     * (See the UIP class and documentation, "UIP.h")
     * This class supports four main types of cellular radio interactions including:
     * configuration and status AT-command processing, SMS processing, TCP Socket data connections,